Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support custom doc template #428

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Aug 29, 2023

This allows to provide a custom doc template instead of https://github.com/plexsystems/konstraint/blob/main/internal/commands/document_template.go which allows to use different output formats (e.g. custom html website or similar)

Copy link
Collaborator

@jalseth jalseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, thanks for the PR! Just a couple of comments.

internal/commands/document.go Outdated Show resolved Hide resolved
internal/commands/document.go Outdated Show resolved Hide resolved
@mrueg mrueg force-pushed the custom-template-doc branch 2 times, most recently from 2340b42 to a61228b Compare August 30, 2023 08:07
@mrueg mrueg force-pushed the custom-template-doc branch from 3c67676 to 14fdc11 Compare August 30, 2023 08:14
@mrueg mrueg force-pushed the custom-template-doc branch from 97187a8 to 9f2bc93 Compare August 30, 2023 10:49
@mrueg
Copy link
Contributor Author

mrueg commented Aug 30, 2023

I also added go:embed this makes it easier for users to fork the default template for their own purposes.

@jalseth jalseth merged commit f6421f7 into plexsystems:main Aug 31, 2023
@mrueg
Copy link
Contributor Author

mrueg commented Aug 31, 2023

@jalseth thanks for the merge! Would you be able to tag a new release as well?

@jalseth
Copy link
Collaborator

jalseth commented Aug 31, 2023

@mrueg The new OPA release was just made, once that is merged we will cut a new release.

jalseth added a commit that referenced this pull request Sep 1, 2023
jalseth added a commit that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants