Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Own dot-notation filter types #410

Closed
avaly opened this issue Jan 24, 2023 · 3 comments · Fixed by #430
Closed

Own dot-notation filter types #410

avaly opened this issue Jan 24, 2023 · 3 comments · Fixed by #430
Assignees
Labels
enhancement New feature or request

Comments

@avaly
Copy link
Collaborator

avaly commented Jan 24, 2023

The MongoDB team is planning to remove the default dot-notation support from the Filter type in the upcoming v5 of the driver.

See: mongodb/node-mongodb-native#3520

We want to adopt those types inside Papr, in order to keep Papr filters type safe.

@avaly avaly added the enhancement New feature or request label Jan 24, 2023
@avaly avaly self-assigned this Jan 24, 2023
@CarlosLozanoHealthCaters
Copy link
Collaborator

Although they are removing dot-notation support from the Filter, they are also creating a new experimental type StrictFilter that keep the dot-notation.

What do you think if we try to convince them to implement a StrictRootFilterOperators too and encourage them to use it in the StrictFilter?

That would solve all our issues, right?

@avaly
Copy link
Collaborator Author

avaly commented Jan 24, 2023

mongodb/node-mongodb-native#3520 (comment)

I would rather not use their StrictFilter types, since they still mix in Document in there. So we'd like to bring those types into Papr and own them. We can definitely follow the upstream changes and bring in improvements as they come in there.

@CarlosLozanoHealthCaters
Copy link
Collaborator

MongoDB has released the v5.0.0 of Node driver with the StrictFilter changes (https://github.com/mongodb/node-mongodb-native/releases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants