Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not exit on build error #244

Open
notramo opened this issue Dec 7, 2022 · 1 comment
Open

Do not exit on build error #244

notramo opened this issue Dec 7, 2022 · 1 comment

Comments

@notramo
Copy link

notramo commented Dec 7, 2022

plenti serve currently exits when it encounters a build error.
This is quite unconventional, as other tools behave differently in this case.

When a build error happens, instead of exiting, Plenti should render a HTML page of the error, and continue watching for file changes. When a file is changed, automatically rebuild, then serve the new version (or, in case of another error, serve the new error as HTML). This is what most web frameworks/SSGs are doing.

@jimafisk
Copy link
Member

jimafisk commented Dec 7, 2022

Great idea @notramo, we could implement something like this when using the local server (plenti serve). Since the deployed applications rely heavily on CI to run, I do want to continue to throw errors that halt the build to avoid shipping a broken site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants