Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass context to the parent of PlaywrightEnvironment #819

Open
juan-fernandez opened this issue Sep 19, 2024 · 1 comment · May be fixed by #820
Open

Pass context to the parent of PlaywrightEnvironment #819

juan-fernandez opened this issue Sep 19, 2024 · 1 comment · May be fixed by #820

Comments

@juan-fernandez
Copy link

This line could be changed and it'd help users of PlaywrightEnvironment to leverage the context that's passed to jest environments

From

    constructor(config: JestEnvironmentConfig) {
      super(config)
      this._config = config.projectConfig as JestPlaywrightProjectConfig
    }

to

    constructor(config: JestEnvironmentConfig, context: EnvironmentContext) {
      super(config, context)
      this._config = config.projectConfig as JestPlaywrightProjectConfig
    }

This is actually how jest recommends creating your own test environment in their docs:

// my-custom-environment
const NodeEnvironment = require('jest-environment-node').TestEnvironment;

class CustomEnvironment extends NodeEnvironment {
  constructor(config, context) {
    super(config, context);
    console.log(config.globalConfig);
    console.log(config.projectConfig);
    this.testPath = context.testPath;
    this.docblockPragmas = context.docblockPragmas;
  }
  ...

Describe the solution you'd like
Passing context when calling super

Additional context
This is an issue specifically for Datadog's test visibility.

If you're OK with this change I can contribute it myself 😄

@juan-fernandez
Copy link
Author

I created a PR just for this: #820

@github-staff github-staff deleted a comment from Kami-prog Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant