Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playwright/expect-expect should allow for the test.expect style #297

Closed
MrJohz opened this issue Jun 13, 2024 · 1 comment
Closed

playwright/expect-expect should allow for the test.expect style #297

MrJohz opened this issue Jun 13, 2024 · 1 comment
Labels

Comments

@MrJohz
Copy link

MrJohz commented Jun 13, 2024

For historical reasons, most of the Playwright tests in my codebase use test.expect(...) instead of directly importing expect from Playwright. I don't really know why, it might have something to do with the use of fixtures.

The playwright/expect-expect lint does not support the use of test.expect(...), and I need to either disable this lint, or rewrite all my tests to use the bare expect(...) version.

Is there a reason why this is the case, or is it just not very common that people use test.expect and I've run into a bug here? In that case, I'm happy to create a pull request to fix this.

Copy link

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant