Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1353, #1355] update python 3 #1394

Merged
merged 24 commits into from
Apr 3, 2022
Merged

[#1353, #1355] update python 3 #1394

merged 24 commits into from
Apr 3, 2022

Conversation

xael-fry
Copy link
Member

@xael-fry xael-fry commented Mar 30, 2022 •
edited
Loading

Pull Request Checklist

Helpful things

Fixes

Fixes #xxxx

Purpose

What does this PR do?

Background Context

Why did you take this approach?

References

Are there any relevant issues / PRs / mailing lists discussions?

tomparle and others added 20 commits March 29, 2022 10:04
@tomparle
upgrade to python 3 : main script working, now needs to test commands
ca97562
@tomparle
fix file access commands
9f730e0
@tazmaniax @tomparle
* playframework#5: Update to latest Eclipse JDT Core v3.23 to enable …
21dcc63 
…JDK 14 source

Task-Url: tazmaniax#5

* playframework#5: Updated Groovy to v3.0.6

Task-Url: tazmaniax#5

* 5: Replace LinkedList with Collection

Task-Url: tazmaniax#5

* Remove old versions of groovy

* Replace reflection based approach to adding compiler phase operation

* Fix groovy template compilation test

A change between Groovy 3.0.4 and 3.0.5 resulted in a change in the
compiler output message

* Updated a few dependencies

Not strictly part of this change but while there is an opportunity :)
@tomparle
fix module commands by upgrading simplejson to latest build
e2ae5a8
@tomparle
remove compatibility lib for Python2, not useful anymore
ebd8b1b
@tomparle
fix calls to past builtins that are not present in Python3
0876e36
@tomparle
upgraded python tests to Python 3
e93cd23
@tomparle
upgraded yaml lib for python 3 support
8ca59ac
@tomparle
resolve conflit with current master branch for rebase
c13ab61
@tomparle
Revert "conflict fix after rebase issues"
57e4e7b 
This reverts commit 31cc030.
@tomparle
Revert "remove deprecated libs"
5f4adaa 
This reverts commit b57b63c.
@tomparle
Revert "resolve conflit with current master branch for rebase"
66415a1 
This reverts commit f302f74.
@tomparle
reverted incorrect merge
78c8cea
@tomparle
resolved merge conflict
0c72f05
@tomparle
upgrade latest changes from master to python 3 syntax
ca81a3f
@tomparle
upgrade build file to use python 3 for ant tests on github
994e5a1
@tomparle
change POpen parameter to be compatible with all 3.x python versions
5d42145
@tomparle
fixed incorrect lib structure for python tests
3a4d69a
@tomparle
fix builtins lib import deprecated in python 3
5bd109a
@xael-fry
[playframework#1355] fix python path for windows
b5d8244
@tomparle
Copy link
Contributor

Thanks @xael-fry for your help on this.
I thought that adding libs like "mechanize" or "html5lib" was only needed in Play python lib folder, but it seems that you needed to add them on system level. Maybe you'll also need to add the "six" lib if not already present.
In the latest windows build, it also seems that the missing lib is "win32pdh" : if you do not have time to add it, I will try that tomorrow.

@xael-fry
Copy link
Member Author

@tomparle The problem seem to be with the kill subprocess, the current kill function doesn't work as expected on windows as play is still running in backgroud

@tomparle
Copy link
Contributor

@xael-fry Thanks for the insight. I recall having played with some other ways to kill the subprocess when migrating to Python 3, but it was not necessary to change at that time.
By the way, did you try to add the lib "win32pdh" which is missing in the latest build ? This seems to have caused the latest build to fail.
If you do not have time, I'll try to find some time to setup a Windows environment.

@xael-fry xael-fry force-pushed the pr_1355_v3 branch 4 times, most recently from 4454c8f to e748cc0 Compare April 3, 2022 07:05
@xael-fry xael-fry force-pushed the pr_1355_v3 branch 2 times, most recently from 675c9b6 to c71f483 Compare April 3, 2022 07:20
@xael-fry xael-fry self-assigned this Apr 3, 2022
@xael-fry xael-fry added this to the 1.7.0 milestone Apr 3, 2022
@xael-fry xael-fry changed the title Pr 1355 v3 [#1353, #1355] update python 3 Apr 3, 2022
@xael-fry
Copy link
Member Author

xael-fry commented Apr 3, 2022

@tomparle it is fix :)... Yes!!!

@xael-fry xael-fry merged commit 6b17d80 into playframework:master Apr 3, 2022
@xael-fry xael-fry deleted the pr_1355_v3 branch April 3, 2022 08:02
@tomparle
Copy link
Contributor

tomparle commented Apr 3, 2022

Yiepeeee !
Congrats, @xael-fry !

@tazmaniax
Copy link
Collaborator

@xael-fry @tomparle nice one guys!!!!

@xabolcs xabolcs mentioned this pull request Apr 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xael-fry xael-fry

Labels
feature has-pr improvement
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xael-fry @tomparle @tazmaniax