Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When should play! migrate to jakarta-jpa? #1390

Open
aleksandy opened this issue Feb 26, 2022 · 6 comments
Open

When should play! migrate to jakarta-jpa? #1390

aleksandy opened this issue Feb 26, 2022 · 6 comments

Comments

@aleksandy
Copy link
Contributor

JPA 3.0 don't have backward compatibility with 1.x-2.x versions because of renaming of all packages. As possible solution I see extracting play.db.jpa package in independent module and make two versions of its: jpa 2.2 and jpa 3.0.

But in my opinion maintaining both versions is too complicated and costly.

@tomparle
Copy link
Contributor

It seems that JPA 3 does not bring any new features, and only change packages for legal issues.
I agree that maintaining two versions would be costly, but what would even be the benefits of migrating to 3.0 ?

@aleksandy
Copy link
Contributor Author

Hi, @tomparle. I believe this is necessary at least to be able to update hibernate up to the next major release.

@tomparle
Copy link
Contributor

Thank you, this is indeed a sufficient reason to migrate.
The migration does not seem very complicated, would you like to propose a PR for this ?

@aleksandy
Copy link
Contributor Author

Yep, I'll send it soon.

@cies
Copy link
Contributor

cies commented Oct 31, 2022

Over at RePlay @asolntsev just upgraded Hibernate to 5.6.12Final which exposes jakarta.validation.* instead of javax.validation.*.

Easy enough to fix, but Hibernate already started the move to jakarta for us (in a minor version).

@xabolcs
Copy link
Contributor

xabolcs commented Nov 1, 2022

JPA 3.0 don't have backward compatibility with 1.x-2.x versions because of renaming of all packages. As possible solution I see extracting play.db.jpa package in independent module and make two versions of its: jpa 2.2 and jpa 3.0.

That would be the best!

But in my opinion maintaining both versions is too complicated and costly.

It is, but it easy to let it rot. 🤷
So just let the contributors do their contributions to keep JPA 2.0 or JPA 3.0 versions alive.
Play! 2 Framework did the same: they shrink the framework by extracting a lot of functionality to it's own module ... and the community have to maintain them.


Same goes for play.server.ServletWrapper: it uses javax.servlet.*
It should be extracted it's own module and / or do it's move to jakarta.servlet when the other modules do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants