-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1383] 🆕 Ability to disable database evolutions on a datasource basis #1384
[#1383] 🆕 Ability to disable database evolutions on a datasource basis #1384
Conversation
… on a datasource basis
@@ -392,6 +392,10 @@ private boolean isDisabled() { | |||
return "false".equals(Play.configuration.getProperty("evolutions.enabled", "true")); | |||
} | |||
|
|||
private static boolean isDatabaseEvolutionDisabled(String dbName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are doing double-negotiation here: "false" -> "Disabled" -> "!Disabled". The code may be slightly simplified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, in fact I just kept the existing "style" to stay coherent with other methods :D
Can be changed if really required ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure. Probably not such important. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@holajsh can you update the documentation https://github.com/playframework/play1/blob/master/documentation/manual/evolutions.textile ?
Thanks
…[DB_name].evolutions.enabled
Sure, I have pushed something but I'm not really sure how to check it will display properly... |
Fixes
Fixes #1383
Purpose
Add support for a new configuration parameter to allow disabling database evolutions per database.
References
#1383