Update to latest Eclipse JDT Core v3.23 to enable JDK 14 source #1338
Conversation
|
I fixed the issue with the old Groovy jars lying around but the build still seems to be broken - not sure what the issue is but I don't think it's related to the changes. |
A change between Groovy 3.0.4 and 3.0.5 resulted in a change in the compiler output message
|
@tomparle @asolntsev @xael-fry finally a good result here! That was a bit painful. So all good under JDK 1.8 but under JDK 15 I get a few failing tests (binding, invocationContext) and a few with errors (errors, routing), but I haven't had a chance to resolve them yet. I'm out of time on this so if anyone else can investigate that would be great! Not sure if these > JDK 1.8 issues are a blocker with accepting this pull request. |
Not strictly part of this change but while there is an opportunity :)
|
@tazmaniax congratulations for your work ! The changes in the Groovy Template do not seem obvious, good job for having figured this out. |
|
merged thanks @tazmaniax |
|
@xael-fry ok looks like the build failure has been resolved so all good - just a bit of a messy commit history
|
tazmaniax
changed the title
|
@tazmaniax Yes I see my mistake after, there was some conflict in merge, but I fix it. |
Applies changes made in playframework#1368 to revert unnecessary and incorrect changes to GroovyTemplate introduced in playframework#1338
Task-Url: tazmaniax#5
Helpful things
Fixes
Updated the Eclipse JDT Core version along with other source compile libraries.
Purpose
Allows code to compile to JDK 14 source level
Background Context
This was being held up because the "Faster Groovy Templates" had a compile issue using Eclipse JDT Core > v18 but this has now been resolved, see references below
References