Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1262] Allow to override default fast tags with empty namespace #1279

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

tuantla
Copy link
Contributor

@tuantla tuantla commented Nov 9, 2018

Allow to override default fast tags with empty namespace

#1262

@asolntsev asolntsev self-requested a review November 12, 2018 06:40
Copy link
Contributor

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xael-fry Good PR. Recommended to merge.

@asolntsev
Copy link
Contributor

@tuantla Is there a chance that you could add a test demonstrating the fixed functionality?

@tuantla
Copy link
Contributor Author

tuantla commented Nov 13, 2018

thanks @asolntsev. I'm on it

@anhtuan84
Copy link

added test the case

@asolntsev
Copy link
Contributor

@xael-fry Good PR. Recommended to merge.

@xael-fry xael-fry added this to the 1.5.3 milestone Dec 13, 2018
@xael-fry xael-fry merged commit 1adcffd into playframework:master Dec 13, 2018
@xael-fry xael-fry changed the title Allow to override default fast tags with empty namespace [#1262] Allow to override default fast tags with empty namespace Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants