Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for glTF extension KHR_lights_punctual #2061

Closed
godiagonal opened this issue May 7, 2020 · 4 comments · Fixed by #3253
Closed

Support for glTF extension KHR_lights_punctual #2061

godiagonal opened this issue May 7, 2020 · 4 comments · Fixed by #3253
Assignees
Labels
area: graphics Graphics related issue

Comments

@godiagonal
Copy link
Contributor

Description

KHR_lights_punctual is a glTF 2.0 extension supported by most major WebGL libraries. We propose that the PlayCanvas built-in glTF parser should support this as it is the current de-facto standard for storing light source information in glTF.

Step to reproduce

  1. Open project https://playcanvas.com/project/684177/overview/khr_lights_punctual-test
  2. Open scene “PointLightTest” and launch it
  3. Open scene “SpotLightTest” and launch it

What I expect to see and what I saw instead

Note that the mocked lights for the “Expected” results are an approximation and might not match exactly what a proper implementation would yield.

Point lights:
Screenshot 2020-05-07 at 09 39 26

Spot lights:
Screenshot 2020-05-07 at 09 39 13

@willeastcott
Copy link
Contributor

Blocked on #2063.

@cx20
Copy link

cx20 commented May 7, 2020

I too am waiting for KHR_lights_punctual to be supported. It would be great to have support for the extensions listed below.

https://github.com/cx20/gltf-test#extension-test-models
image

Test model:
https://github.com/cx20/gltf-test/tree/master/tutorialModels/Lights

@cx20
Copy link

cx20 commented Jun 24, 2021

I have confirmed that this extension is available in the latest version of PlayCanvas and updated the status of gltf-test.

PlayCnavas v1.44.0-dev + Light.gltf result:
image

image

@willeastcott
Copy link
Contributor

Thanks for confirming that this test now passes, @cx20. You're the best! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants