Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not compatible with Gen 3 #20

Open
botris opened this issue Jun 11, 2021 · 0 comments
Open

Not compatible with Gen 3 #20

botris opened this issue Jun 11, 2021 · 0 comments

Comments

@botris
Copy link

botris commented Jun 11, 2021

In Gen 3, the production branch is master, but the Config->onProduction() does:

$prodBranch = $this->onDedicated() ? 'production' : 'master';

Which results in false while in fact you are on "production".

I don't know if there are variables to check if you are on Gen 3, but that would need to be included in the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@botris