Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xor should be or in example #5

Open
norpan opened this issue Feb 11, 2020 · 0 comments
Open

xor should be or in example #5

norpan opened this issue Feb 11, 2020 · 0 comments

Comments

@norpan
Copy link

norpan commented Feb 11, 2020

platform-sifive/examples/native-blink_asm/src/setLED.S

Line 32 in 168f42b

xor t1, t1, a0 # Do an XOR to only change the the value of the requested LED

To just set the bit specified, you should use or, not xor. Using xor will unset the bit if it was set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@norpan