Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled text input form elements appear too prominent and look active #361

Closed
jhung opened this issue May 28, 2020 · 3 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jhung
Copy link
Contributor

jhung commented May 28, 2020

Describe the bug

Disabled state is using a lighter grey than design specs - still looks like an active field.

Screenshots

image

@jhung jhung added the bug Something isn't working label May 28, 2020
@jhung jhung changed the title Disabled text input form elements Disabled text input form elements appear too prominent and look active May 28, 2020
@greatislander
Copy link
Collaborator

@jhung can you clarify? I'm a bit confused by this issue; lighter would make it look less like an active field , I'd think.

@jhung
Copy link
Contributor Author

jhung commented Jun 2, 2020

@greatislander
The original text from the pinecone review spreadsheet said: "Disabled state is using a lighter grey than design specs - still looks like ean [sic] active field"

I think just confirm the following colors while you're poking around in there:

Default Background: #F0EFEF;
Default Border: ##B2B2A7;

Inverted Background: #D5D5CF;
Inverted Border: #B2B2A7;

From the spec:
image

@greatislander
Copy link
Collaborator

@jhung can you open a PR for this?

@greatislander greatislander added this to the 1.0.0-beta.3 milestone Jun 2, 2020
@greatislander greatislander assigned jhung and greatislander and unassigned jhung Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants