Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent top level checkbox overlap (fixes #292) #347

Merged
merged 2 commits into from
May 15, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented May 14, 2020

Description

This fixes an issue where a top-level checkbox in the filter list would be overlapped by the disclosure button.

Steps to test

  1. Review component: https://deploy-preview-347--pinecone.netlify.app/components/preview/archive--default

Expected behavior: Goals → Build a Platform or Protocol should wrap instead of being overlapped by the disclosure button as it is here: https://resources.platform.coop/resources/

Additional information

Not applicable.

Related issues

Fixes #292.

@greatislander greatislander added the bug Something isn't working label May 14, 2020
@greatislander greatislander added this to the 1.0.0-beta.1 milestone May 14, 2020
@greatislander greatislander self-assigned this May 14, 2020
@netlify
Copy link

netlify bot commented May 14, 2020

Deploy preview for pinecone ready!

Built with commit 1b08c3a

https://deploy-preview-347--pinecone.netlify.app

@cherylhjli
Copy link

Looks great!
Hoping to left align the text on the second line to the first, rather than having it wrap under the checkbox - any chance this wouldn't be too complicated?

Archive_Default_Pinecone

@greatislander
Copy link
Collaborator Author

@cherylhjli That's a separate task, I think— it would involve work on this custom element plus radio buttons and checkboxes. If you could open a ticket for it I could tackle it at some point in the future.

@greatislander greatislander merged commit 57f14f7 into dev May 15, 2020
@greatislander greatislander deleted the fix/disclosure-button-overlap branch May 15, 2020 15:39
greatislander added a commit that referenced this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top level checkbox label in filter list is covered by disclosure button
2 participants