Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add split dividers (resolves #328) #344

Merged
merged 4 commits into from
May 14, 2020
Merged

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented May 14, 2020

Description

This PR implements a responsive blocks molecule, with an optional text divider.

TODO:

  • Inverse variant

Steps to test

  1. Review component: https://deploy-preview-344--pinecone.netlify.app/components/detail/responsive-blocks.html.

Expected behavior: Layout behaves as expected on mobile and desktop layouts.

Additional information

Not applicable.

Related issues

Resolves #328.

@greatislander greatislander added the enhancement New feature or request label May 14, 2020
@greatislander greatislander added this to the 1.0.0-beta.1 milestone May 14, 2020
@greatislander greatislander self-assigned this May 14, 2020
@greatislander greatislander added the needs-design This feature depends on designs label May 14, 2020
@netlify
Copy link

netlify bot commented May 14, 2020

Deploy preview for pinecone ready!

Built with commit 5fea730

https://deploy-preview-344--pinecone.netlify.app

@cherylhjli
Copy link

Looks great! Inverse can be off white.

@greatislander greatislander marked this pull request as ready for review May 14, 2020 16:07
@greatislander greatislander changed the title feat: add split dividers [WIP] (resolves #328) feat: add split dividers (resolves #328) May 14, 2020
@greatislander greatislander merged commit ba390aa into dev May 14, 2020
@greatislander greatislander deleted the add/text-divider branch May 14, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-design This feature depends on designs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create split dividers/<hr>s
2 participants