fix: resolve issue with byline appearing inline with resource title on home feed #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed .home__feed header style that was causing elements to flex and appear inline. resolve #257
|
Deploy preview for pinecone ready! Built with commit aad6845 |
greatislander
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #257 .
Steps to test
home.config.jslines 63 and 64 to generate 1 word title and bylines (i.e. min: 1, max: 1).npm run buildfractal startExpected behavior:
The byline for a resource should be on its own line regardless of the length of the title or byline string.
Additional information
Not applicable.
Related issues
Resolves #257 .