Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new format icons (resolves #211) #217

Merged
merged 3 commits into from
Jan 31, 2020
Merged

feat: add new format icons (resolves #211) #217

merged 3 commits into from
Jan 31, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jan 30, 2020 •
edited
Loading

Description

Adds new format icons, and a save icon.

Steps to test

Review icons component and archive component:

Additional information

Not applicable.

Related issues

@greatislander greatislander self-assigned this Jan 30, 2020
@greatislander greatislander added the enhancement New feature or request label Jan 30, 2020
@greatislander greatislander added this to the 1.0.0-alpha.10 milestone Jan 30, 2020
@netlify
Copy link

netlify bot commented Jan 30, 2020 •
edited
Loading

Deploy preview for pinecone ready!

Built with commit 8996807

https://deploy-preview-217--pinecone.netlify.com

@greatislander greatislander mentioned this pull request Jan 30, 2020
Closed
2 tasks
@cherylhjli
Copy link

Not sure if this is wrapped up in this PR...

  • external link icon outdated
  • Missing author icon

Also,

  • It seems like all the icons are sitting a bit lower compared to the line of text beside is - can it be inched up by a pixel or two? A good way to check is if the document icon is sitting centre-aligned horizontally with its accompanying label

@greatislander
Copy link
Collaborator Author

greatislander commented Jan 31, 2020 •
edited
Loading

@cherylhjli The external link is added in the call to action PR and the author icon is in the other PR you reviewed. I've adjusted icon positioning, please take another look.

@greatislander greatislander changed the title feat: add new format icons (resolves #211) feat: add new format icons (resolves #211) Jan 31, 2020
@greatislander greatislander merged commit 0e5b296 into dev Jan 31, 2020
@greatislander greatislander deleted the add/format-icons branch January 31, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhung jhung jhung approved these changes

@cherylhjli cherylhjli Awaiting requested review from cherylhjli

Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.10
Development

Successfully merging this pull request may close these issues.

New format icons
3 participants
@greatislander @cherylhjli @jhung