feat: add author icon to resource card (resolves #214) #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatislander
changed the title
greatislander
requested review from
cherylhjli and
jhung
and removed request for
cherylhjli
|
Deploy preview for pinecone ready! Built with commit 1f54887 |
|
It looks great! |
|
The spacing is off, it turns out, because of the trick with the periods/middle dots as separators. I haven't figured out a solution yet. |
jhung
approved these changes
Jan 31, 2020
|
Fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds author icon to resource card bylines.
Steps to test
Review resource card component: https://deploy-preview-216--pinecone.netlify.com
Additional information
Not applicable.
Related issues