Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atom: favorites indicator #193

Closed
greatislander opened this issue Jan 24, 2020 · 0 comments · Fixed by #209
Closed

Atom: favorites indicator #193

greatislander opened this issue Jan 24, 2020 · 0 comments · Fixed by #209
Assignees
@dayotte @cherylhjli
Labels
enhancement New feature or request needs-design This feature depends on designs
Milestone
1.0.0-alpha.10

Comments

@greatislander
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

We need to represent whether a resource is in a user's favorites list or not on both the card and single resource view.

Describe the solution you'd like

The heart icon plus accessible text can be used to reflect this independently from the "Add to / Remove from favorites" button.

Describe alternatives you've considered

Not applicable.

Additional context

Not applicable.
@greatislander greatislander added enhancement New feature or request needs-design This feature depends on designs labels Jan 24, 2020
@greatislander greatislander added this to the 1.0.0-alpha.9 milestone Jan 24, 2020
@greatislander greatislander mentioned this issue Jan 28, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dayotte dayotte

@cherylhjli cherylhjli

Labels
enhancement New feature or request needs-design This feature depends on designs
Projects
None yet
Milestone
1.0.0-alpha.10
Development

Successfully merging a pull request may close this issue.

feat: improve card semantics (resolves #190) platform-coop-toolkit/pinecone
3 participants
@greatislander @dayotte @cherylhjli