Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only show language switcher if enabled via localization settings #251

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

greatislander
Copy link
Collaborator

Description

If no languages are checked in the new Localization settings panel, the language switcher should not be shown. Otherwise, it should include only checked languages.

Steps to test

  1. Uncheck all languages in Localization settings, save.
  2. Check front end.
  3. Check some languages in Localization settings, save.
  4. Check front end.

Expected behavior: Behavior matches description.

Additional information

Not applicable.

Related issues

Not applicable.

@greatislander greatislander added the enhancement New feature or request label Apr 1, 2020
@greatislander greatislander added this to the 1.0.0-rc.1 milestone Apr 1, 2020
@greatislander greatislander requested a review from jhung April 1, 2020 16:52
@greatislander greatislander self-assigned this Apr 1, 2020
@greatislander greatislander merged commit d3c3073 into dev Apr 1, 2020
@greatislander greatislander deleted the add/language-control branch April 1, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants