Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notification for filtered search with no results (fix #249) #250

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

greatislander
Copy link
Collaborator

Description

Adds assertive and visual notifications for filtered search results which produce zero matches.

Steps to test

  1. Search for "capitalism".
  2. Filter by sector: "Childcare & Hospice".

Expected behavior: Screen reader announces "1 filter applied. No resources found." A visible notice is added to the screen.

Additional information

Not applicable.

Related issues

@greatislander greatislander requested a review from jhung March 31, 2020 21:09
@greatislander greatislander self-assigned this Mar 31, 2020
@greatislander greatislander added the enhancement New feature or request label Mar 31, 2020
@greatislander greatislander added this to the 1.0.0-rc.1 milestone Mar 31, 2020
@greatislander greatislander merged commit cedc949 into dev Apr 1, 2020
@greatislander greatislander deleted the fix/filtered-search branch April 1, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve / fix filtering search results that produces no matches
2 participants