Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly handle new publication date formatting (resolves #245) #248

Merged
merged 3 commits into from
Mar 31, 2020

Conversation

greatislander
Copy link
Collaborator

Description

This PR incorporates changes from platform-coop-toolkit/coop-library-framework#334 and fixes an issue where publication dates that only consisted of a year or a year and a month would be incorrectly formatted.

Steps to test

  1. Visit "Browse All" and sort by publication date.
  2. Visit resources with year, year and month, and year, month, and day publication dates.

Expected behavior: Publication dates are formatted correctly no matter how many components are provided; resources can be sorted properly by publication date.

Additional information

Not applicable.

Related issues

@greatislander greatislander added the enhancement New feature or request label Mar 31, 2020
@greatislander greatislander added this to the 1.0.0-rc.1 milestone Mar 31, 2020
@greatislander greatislander requested a review from jhung March 31, 2020 18:05
@greatislander greatislander self-assigned this Mar 31, 2020
@greatislander greatislander merged commit 0741e36 into dev Mar 31, 2020
@greatislander greatislander deleted the fix/resource-publication-date branch March 31, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort by date published behaves unexpectedly
2 participants