feat: announce filters once applied (resolves #130) #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhung
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
I think this is a fine solution for now. If we have more such informative messages, we may want to figure out a more accessible landmark for these messages (currently you have to traverse the entire document to get to the message if you want to hear it again).
|
@jhung There's also the "Current Filters" area which gives more detail. I wonder if we can adapt that to include the live area. If you want to open a follow-up ticket, please do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds screen reader feedback after applying filters.
Steps to test
Expected behavior: Screen reader announces:
Additional information
Not applicable.
Related issues