Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: visual designs #222

Merged
merged 12 commits into from
Mar 12, 2020
Merged

feat: visual designs #222

merged 12 commits into from
Mar 12, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Mar 11, 2020

Description

Implements visual designs from https://files.inclusivedesign.ca/s/mz0ANL9RlXo8ij6.

Steps to test

  1. Visit Home, About, Browse All, Topics, Goals, Co-op Types, Sectors, and Formats.

Expected behavior: Implementation should align with designs.

Additional information

Not applicable.

Related issues

@greatislander greatislander added the enhancement New feature or request label Mar 11, 2020
@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Mar 11, 2020
@greatislander greatislander requested a review from jhung March 11, 2020 21:29
@greatislander greatislander self-assigned this Mar 11, 2020
@greatislander greatislander marked this pull request as ready for review March 11, 2020 21:48
Copy link
Contributor

@jhung jhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The front page has an issue with text contrast, but otherwise everything else in this PR looks fine.


.page.home .banner-pattern {
background: var(--blue-500);
background-image: url("../images/home.svg");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Affected by #224 - insufficient text to background contrast.

@greatislander greatislander merged commit 4f13534 into dev Mar 12, 2020
@greatislander greatislander deleted the add/visual-designs branch March 12, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visual designs
2 participants