Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom pagination (resolves #188) #209

Merged
merged 29 commits into from
Mar 6, 2020
Merged

feat: custom pagination (resolves #188) #209

merged 29 commits into from
Mar 6, 2020

Conversation

greatislander
Copy link
Collaborator

Description

This PR adds a custom pagination method (App\Controllers\App::getPagination()) which is used in place of get_the_posts_pagination().

Steps to test

  1. Inspect pagination on "Browse all" page.
  2. Inspect pagination on search results pages.
  3. Add more than 12 favorites, then inspect pagination on favorites page.

Expected behavior: Markup and behaviour matches Pinecone specifications.

Additional information

Not applicable.

Related issues

@greatislander
fix: use new tag buttons in current filters, use Pinecone search form
8ed90a1
@greatislander
feat: allow search results to be filtered
11149a4
@greatislander
fix: only search resources
832f1b7
@greatislander
feat: add save search button and search term display
0fbfd01
@greatislander
Merge branch 'dev' into add/search-results
e81f059
@greatislander
fix: don't run code twice on search results page
80b57d3
@greatislander
feat: saved search functionality
a178762
@greatislander
Merge branch 'dev' into add/search-results
9d122b0
@greatislander
fix: notification positioning
95d50b6
@greatislander
feat: limit saved searches to 25
1bb1881
@greatislander
feat: limit saved searches to 50 instead of 25
fb961dc
@greatislander
fix: resolve PHPCS error
9549bf5
@greatislander
fix: paginate search results
e7a9600
@greatislander
Merge branch 'dev' into add/search-results
40974eb
@greatislander
Merge branch 'dev' into add/search-results
6d39d3f
@greatislander
Merge branch 'dev' into add/search-results
35ce02e
@greatislander
fix: set post type in pre_get_posts
434e0b2
@greatislander
Revert "fix: set post type in pre_get_posts"
5dfde3d 
434e0b2
@greatislander
fix: move str_replace into controllers
886e1b2
@greatislander
feat: add current and total params for paginating non-WP queries
5e4026c
@greatislander
fix: revert precommit hook
288f1a2
@greatislander
fix: remove unnecessary library
ceed4a7
@greatislander
feat: retrieve current page
8a1b67e
@greatislander
Merge branch 'add/search-results' into add/custom-pagination
f97a4f5
@greatislander
feat: rough order for pagination output
0a1522e
@greatislander
Merge branch 'dev' into add/custom-pagination
f577141 
# Conflicts:
#	app/Controllers/App.php
#	resources/assets/scripts/routes/saved-searches.js
#	resources/views/partials/content-page-saved-searches.blade.php
#	resources/views/search.blade.php
@greatislander
feat: add custom pagination
9f4bac9
@greatislander
fix: linting errors
e15c322
@greatislander greatislander added the enhancement New feature or request label Mar 2, 2020
@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Mar 2, 2020
@greatislander greatislander requested a review from jhung March 2, 2020 23:32
@greatislander greatislander self-assigned this Mar 2, 2020
@greatislander greatislander changed the title feat: custom pagination (resolves feat: custom pagination (resolves #188) Mar 2, 2020
@greatislander greatislander merged commit 7e707e4 into dev Mar 6, 2020
@greatislander greatislander deleted the add/custom-pagination branch March 6, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhung jhung jhung approved these changes

Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.

Custom pagination
2 participants
@greatislander @jhung