Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: limit short title to 72 characters (resolves #271) #289

Merged
merged 2 commits into from
Feb 25, 2020
Merged

feat: limit short title to 72 characters (resolves #271) #289

merged 2 commits into from
Feb 25, 2020

Conversation

greatislander
Copy link
Collaborator

Description

Adds a character counter and limits short titles to 72 characters.

Steps to test

Edit a short title. Confirm that short title is truncated to 72 characters.

Additional information

Uses this functionality in CMB2: CMB2/CMB2#1276

Related issues

@greatislander greatislander added the enhancement New feature or request label Feb 23, 2020
@greatislander greatislander added this to the 1.0.0-alpha.3 milestone Feb 23, 2020
@greatislander greatislander requested a review from jhung February 23, 2020 22:50
@greatislander greatislander self-assigned this Feb 23, 2020
@greatislander greatislander merged commit 71ece51 into dev Feb 25, 2020
@greatislander greatislander deleted the add/short-title-limit branch February 25, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhung jhung jhung approved these changes

Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.3
Development

Successfully merging this pull request may close these issues.

Character limit for short title
2 participants
@greatislander @jhung