Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the label helper method does not remove :as from the label_html #472

Closed
23inhouse opened this issue Feb 25, 2012 · 2 comments · Fixed by #473
Closed

the label helper method does not remove :as from the label_html #472

23inhouse opened this issue Feb 25, 2012 · 2 comments · Fixed by #473

Comments

@23inhouse
Copy link

The label helper correctly changes the class from "string required" to "boolean required", but it adds as="boolean" to html output.

<% f.label, :name, {:as => :boolean} %>
<label as="boolean" class="boolean required" for="blog_name"><abbr title="required">*</abbr> Name</label>

❤️
@nashby nashby mentioned this issue Feb 25, 2012
Merged
@nashby
Copy link
Collaborator

nashby commented Feb 25, 2012

sorry, forgot to add "closes #472" to commit message. Close it somebody please

@rafaelfranca
Copy link
Collaborator

@nashby thanks again mate!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

except :as from label_html options nashby/simple_form
3 participants
@rafaelfranca @23inhouse @nashby