diff --git a/src/environments/NewEnvironmentDialog.tsx b/src/environments/NewEnvironmentDialog.tsx index 999c8e8..335b666 100644 --- a/src/environments/NewEnvironmentDialog.tsx +++ b/src/environments/NewEnvironmentDialog.tsx @@ -221,7 +221,7 @@ function _NewEnvironmentDialog(props: INewEnvironmentDialogProps) { path: ENV_PREFIX, data }); - if (response?.uid !== undefined) { + if (response?.status === 'ok') { window.location.reload(); } else { handleClose(); diff --git a/tljh_repo2docker/binderhub_builder.py b/tljh_repo2docker/binderhub_builder.py index 745c468..1248323 100644 --- a/tljh_repo2docker/binderhub_builder.py +++ b/tljh_repo2docker/binderhub_builder.py @@ -82,7 +82,7 @@ async def post(self): ) self.set_status(200) self.set_header("content-type", "application/json") - self.finish(json.dumps({"uid": str(uid)})) + self.finish(json.dumps({"uid": str(uid), "status": "ok"})) log = "" async with db_context() as db: diff --git a/ui-tests/binderhub_snapshots/ui.test.ts/environment-dialog.png b/ui-tests/binderhub_snapshots/ui.test.ts/environment-dialog.png index 9b4a5d7..7bffcb0 100644 Binary files a/ui-tests/binderhub_snapshots/ui.test.ts/environment-dialog.png and b/ui-tests/binderhub_snapshots/ui.test.ts/environment-dialog.png differ diff --git a/ui-tests/binderhub_snapshots/ui.test.ts/running-servers.png b/ui-tests/binderhub_snapshots/ui.test.ts/running-servers.png index c1d35b0..1276c50 100644 Binary files a/ui-tests/binderhub_snapshots/ui.test.ts/running-servers.png and b/ui-tests/binderhub_snapshots/ui.test.ts/running-servers.png differ diff --git a/ui-tests/binderhub_snapshots/ui.test.ts/server-remove-confirm.png b/ui-tests/binderhub_snapshots/ui.test.ts/server-remove-confirm.png index 083a256..09f970b 100644 Binary files a/ui-tests/binderhub_snapshots/ui.test.ts/server-remove-confirm.png and b/ui-tests/binderhub_snapshots/ui.test.ts/server-remove-confirm.png differ diff --git a/ui-tests/playwright.config.js b/ui-tests/playwright.config.js index b0365c9..05942d8 100644 --- a/ui-tests/playwright.config.js +++ b/ui-tests/playwright.config.js @@ -9,9 +9,9 @@ module.exports = { use: { baseURL: 'http://localhost:8000', video: 'retain-on-failure', - trace: 'on-first-retry' + trace: 'retain-on-failure' }, - retries: 1, + retries: 0, expect: { toMatchSnapshot: { maxDiffPixelRatio: 0.001 diff --git a/ui-tests/tests/ui.test.ts b/ui-tests/tests/ui.test.ts index abddfe4..23ec77b 100644 --- a/ui-tests/tests/ui.test.ts +++ b/ui-tests/tests/ui.test.ts @@ -142,7 +142,7 @@ test.describe('tljh_repo2docker UI Tests', () => { name: 'Create Server' }); await createServer.click(); - await expect(createServer).toHaveCount(0); + await expect(createServer).toHaveCount(0, { timeout: 20000 }); await page.waitForURL('**/servers'); await page.waitForTimeout(1000);