Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-enumerable Symbols for BLeak-internal properties #15

Open
jvilk opened this issue Feb 14, 2018 · 1 comment
Open

Use non-enumerable Symbols for BLeak-internal properties #15

jvilk opened this issue Feb 14, 2018 · 1 comment

Comments

@jvilk
Copy link
Member

jvilk commented Feb 14, 2018

We currently add special BLeak properties to some objects. These are enumerable and visible to the instrumented program.

We should switch to using non-enumerable Symbols so the program cannot accidentally mess with our instrumentation.

This is low-priority as I have not encountered this issue in practice.

@jvilk
Copy link
Member Author

jvilk commented Feb 25, 2018

I've made a number of these non-enumerable now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant