Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Plugin not highlighting in versions >1.3.0 #86

Open
jessykalycia opened this issue Mar 8, 2021 · 7 comments
Open

[vscode] Plugin not highlighting in versions >1.3.0 #86

jessykalycia opened this issue Mar 8, 2021 · 7 comments
Labels
question Further information is requested

Comments

@jessykalycia
Copy link

jessykalycia commented Mar 8, 2021

Version(if relevant): Higher than 1.3.0

Expected:

Visual studio code plugin to highlight "Any" variables;

Actual:

Visual studio code plugin is not highlighting "Any" variables in versions > 1.3.0

Note: Settings/Extensions/Type Coverage is checked on to active and is active on the workspace.

@plantain-00
Copy link
Owner

plantain-00 commented Mar 8, 2021

I cannot reproduce this.
More information is needed.

@plantain-00 plantain-00 added the question Further information is requested label Mar 8, 2021
@jessykalycia
Copy link
Author

jessykalycia commented Mar 8, 2021

Is there any additional configuration needed to highlight the "Any" variables?

Also, what information can I provide to help reproducing easier?

@plantain-00
Copy link
Owner

No additional configuration.

@danvk
Copy link
Contributor

danvk commented Aug 28, 2021

The VS Code extension works in some projects but not others. I haven't been able to pin down what the important difference between the projects is, but it will either report all the any symbols or just not report anything.

For example, the extension works for me on this project: https://github.com/paulirish/webtreemap-cdt

image

but it does not report any any types on this project, even when I add them: https://github.com/danvk/literate-ts

image

type-coverage v2.16.5

Visual Studio Code
Version: 1.59.1
Commit: 3866c3553be8b268c8a7f8c0482c0c0177aa8bfa
Date: 2021-08-19T11:53:52.479Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin x64 19.6.0

@plantain-00
Copy link
Owner

@danvk I cannot reproduce your case
屏幕快照 2021-08-29 09 34 35
The only difference is OS: Darwin x64 18.7.0

@danvk
Copy link
Contributor

danvk commented Aug 29, 2021

I think I found the issue: to get the VS Code extension to work, I also have to install ts-plugin-type-coverage in my project's workspace:

yarn add ts-plugin-type-coverage -D

and then restart VS Code. Note that I'm using my workspace's version of TypeScript:

image

Does this seem right? Perhaps this could be added to the docs for the extension, or it could be bundled.

@plantain-00
Copy link
Owner

@danvk ts-plugin-type-coverage is a dependency of the plugin: https://github.com/plantain-00/type-coverage/blob/master/packages/vscode/package.json#L25
It seems not right, but I will add a reference to this in the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants