-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate examples used in documentation #115
Conversation
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 6 6
Lines 336 336
Branches 39 39
=======================================
Hits 325 325
Misses 9 9
Partials 2 2 |
@@ -62,7 +62,7 @@ coverage rather than decreasing it. | |||
|
|||
We use [pytest][pytest-docs] as our testing framework. | |||
|
|||
#### Stages | |||
### Stages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something seemed odd with the level of the headings in this document (on this line and this one). I've made a best-guess at what they should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! :D LGTM. As long as the examples template into the docs correctly (which I'll try to run myself as well shortly) then ✨ 🚀
The example references don't seem to work when mkdocs templated- maybe need a plugin?
So I was able to run the
Edit:
I accessed it locally at I wonder if Pydantic uses a plugin to facilitate that linking? I was able to find this Pydantic Issue (it gets a bit salty / heated 😆 ) but unfortunately wasn't able to find any reference to how they accomplish the linking in their docs. 😿 |
Thanks, @joaufi ! |
Ok, I added the necessary, missing extension (markdown-include) and this is working now. @joaufi : Do you mind taking one last look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment
To fix #85, we should: