Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to intern all strings #139

Closed
GiedriusS opened this issue Sep 13, 2024 · 0 comments · Fixed by #140
Closed

Add ability to intern all strings #139

GiedriusS opened this issue Sep 13, 2024 · 0 comments · Fixed by #140

Comments

@GiedriusS
Copy link
Contributor

I propose adding a new flag called intern that would call unique.Make() on all strings in the generated code. This is a new feature in Go 1.23. It should help to reduce memory usage immensely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

features/unmarshal: implement unmarshal_unique thanos-community/vtprotobuf
1 participant
@GiedriusS