Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync doesn't cancel when creating new wallet #728

Closed
dreacot opened this issue Dec 22, 2021 · 0 comments · Fixed by #777
Closed

sync doesn't cancel when creating new wallet #728

dreacot opened this issue Dec 22, 2021 · 0 comments · Fixed by #777
Assignees
Labels
bug Something isn't working

Comments

@dreacot
Copy link
Collaborator

dreacot commented Dec 22, 2021

It was noticed on godcr that while syncing a wallet, and attempting to create a new wallet, the log output gets stuck on [INF] DLWL: Canceling sync. May take a while for sync to fully cancel., it's important to know the UI is still usable when this happens, quitting the app and reopening shows that the new wallet was never created.

The error was easily reproduced on a fresh install of godcr with no prior databases.

This dcrlibwallet PR planetdecred/dcrlibwallet#156 added the capability for the library to automatically cancel sync while creating/deleting a wallet, as opposed to doing that manually in the client apps.

The change was implemented into dcrandroid by this PR planetdecred/dcrandroid#534, and the functionality was tested to work as intended.

The change was implemented into dcrios by this PR https://github.com/planetdecred/dcrios/pull/736/files, and the functionality was tested to work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants