-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce RuneSummon #2258
Introduce RuneSummon #2258
Conversation
ipdae
commented
Nov 28, 2023
•
edited
Loading
edited
- Introduce RuneSummon action
9326922
to
8c6c71b
Compare
Lib9c/Action/RuneSummon.cs
Outdated
public int SummonCount; | ||
|
||
private const int SummonLimit = 10; | ||
public const int RuneQuantity = 100; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, it seems quite inconvenient to change quantity of rune summoned.
Can we separate it to Sheet data or somewhere easier to manage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think quantity provided in the summons is unlikely to be flexible.
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |