Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump react-router version to support nesting and subview properly #2115

Open
Akamig opened this issue Mar 10, 2023 · 1 comment
Open

Bump react-router version to support nesting and subview properly #2115

Akamig opened this issue Mar 10, 2023 · 1 comment
Assignees
@Akamig
Labels
dependencies Pull requests that update a dependency file

Comments

@Akamig
Copy link
Member

Akamig commented Mar 10, 2023

https://reactrouter.com/en/main/upgrading/v5

react-router provides how to migrate their package from v5, and seems there's not much breaking change affecting our repo, and giving us nice nested route for subview.
@Akamig
Copy link
Member Author

Akamig commented Mar 10, 2023 •
edited
Loading

#2114 (comment)

Oh, nevermind about subview.

But still react-router needed updated I guess.

@Akamig Akamig self-assigned this Mar 10, 2023
@Akamig Akamig added the enhancement New feature or request label Mar 10, 2023
@Akamig Akamig added dependencies Pull requests that update a dependency file and removed enhancement New feature or request labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Akamig Akamig

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Akamig