Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version update also updates the a public dependency #94

Open
miraclx opened this issue May 10, 2023 · 2 comments
Open

Version update also updates the a public dependency #94

miraclx opened this issue May 10, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@miraclx
Copy link
Contributor

miraclx commented May 10, 2023

This is a tricky one..

Provided a workspace, with the members foo, bar and syn.

  • foo depends on the local syn at path ../syn
  • bar depends on the public crate syn from crates.io

cargo ws version major will act on all the local crates foo, bar and syn. In this order:

  • Bump the version of the local syn crate.
  • Bump the version of the local foo crate.
    • Update foo's dependency on the local syn crate to the new version.
  • Bump the version of the local bar crate.
    • Update bar's dependency on the public syn crate to the new version of the local crate.

The last tick there is the issue. cargo ws doesn't properly disambiguate between local crates and public ones.

The branch miraclx/crate-conflict is a stage for reproducing this experiment.

@pksunkara pksunkara changed the title Version update map doesn't isn't keyed properly Version update also updates the a public dependency May 10, 2023
@pksunkara
Copy link
Owner

Unfortunately, I think we need to implement the update logic with a proper TOML parser for this to be fixed.

@miraclx
Copy link
Contributor Author

miraclx commented May 15, 2023

Figured out a resolution for this, as well as a couple more edge cases in my fork.

@pksunkara pksunkara added the bug Something isn't working label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants