Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code linting changes, additional comments, and a variable rename #10

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

michelcrypt4d4mus
Copy link

Just a series of small changes I made while reading the code base that should have zero functional impact.

  1. Add a lot of semicolons
  2. Add some comments about what i understand the code to be doing
  3. Rename featureScorer variable to featureScorers because it's an array
  4. Alphabetize some imports and insert some whitespace
  5. Cleanup multiline code that calculates mean and currentMean for readability

There are 4 tests that fail when I run npm run test but those tests are also failing on the main branch so I don't think I broke anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant