Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: remove duplicated --dry-run in --help #595

Merged
merged 1 commit into from
May 26, 2023
Merged

Typo: remove duplicated --dry-run in --help #595

merged 1 commit into from
May 26, 2023

Conversation

beyarkay
Copy link
Contributor

The current verbose help has this list of flags:

flags:
[...]
  --dry-run,-n             don’t do anything, just print
[...]
  --dry-run,-n             don’t execute, just print

Which has the --dry-run flag duplicated. This commit removes the second instance. Since the wording was slightly different for each of the instances, I kept the wording and the ordering as is used for the "less verbose" version of --help, which looks like:

flags:
  --sync,-S       sync and update environment packages
  --env,-E        inject local environment
  --dry-run,-n    don’t do anything, just print

The current verbose help has this list of flags:

```
      flags:
...
        --dry-run,-n             don’t do anything, just print
...
        --dry-run,-n             don’t execute, just print
```

Which has the `--dry-run` flag duplicated. This commit removes the second instance. Since the wording was slightly different for each of the instances, I kept the wording and the ordering as is used for the "less verbose" version of `--help`, which looks like:

```
flags:
  --sync,-S       sync and update environment packages
  --env,-E        inject local environment
  --dry-run,-n    don’t do anything, just print
```
@what-the-diff
Copy link

what-the-diff bot commented May 26, 2023

PR Summary

  • Removed --dry-run flag
    The --dry-run flag has been removed, simplifying the command usage.

@coveralls
Copy link

Coverage Status

Coverage: 75.774%. Remained the same when pulling 2a1810b on beyarkay:patch-1 into 9037e1d on teaxyz:main.

@mxcl mxcl merged commit 654ba20 into pkgxdev:main May 26, 2023
@beyarkay
Copy link
Contributor Author

Thanks for tea! I'm really excited to see what it can do for the OSS community 😄

@beyarkay beyarkay deleted the patch-1 branch May 27, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants