-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test coverage > 80% 🤞 #482
Conversation
PR Summary
|
src/vendor/Path.ts
Outdated
} | ||
yield res.value | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to re-throw if there's an error? And would this work more simply?
for await(const line of lines) {
yield line.value
}
fd.close()
or will it actually throw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that's much better, I even did it that way in the test code. And the try/finally will allow the error to continue up the stack while correctly freeing the file resource, so catch and rethrow is no necessary.
PR Summary
|
Removed some unused functions in utils and added tests for
Path
to try to get to 80%