Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize dependencies #6

Open
bkuczenski opened this issue Oct 11, 2018 · 0 comments
Open

Minimize dependencies #6

bkuczenski opened this issue Oct 11, 2018 · 0 comments

Comments

@bkuczenski
Copy link
Collaborator

The lca_disclosures package should not depend on any specific implementation (like bw2, lcopt, or lca-tools). Ideally, anything a specific subclass needs should be passed as an argument.

Implications:

  • importers don't (necessarily) belong in this class, unless they can meet the above requirement
  • tests that require implementation frameworks are not really unit tests, but integration tests, and maybe don't belong?

Dependency on pandas and scipy are ok because they concern core class functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant