You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The lca_disclosures package should not depend on any specific implementation (like bw2, lcopt, or lca-tools). Ideally, anything a specific subclass needs should be passed as an argument.
Implications:
importers don't (necessarily) belong in this class, unless they can meet the above requirement
tests that require implementation frameworks are not really unit tests, but integration tests, and maybe don't belong?
Dependency on pandas and scipy are ok because they concern core class functionality.
The text was updated successfully, but these errors were encountered:
The
lca_disclosures
package should not depend on any specific implementation (like bw2, lcopt, or lca-tools). Ideally, anything a specific subclass needs should be passed as an argument.Implications:
Dependency on pandas and scipy are ok because they concern core class functionality.
The text was updated successfully, but these errors were encountered: