Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication from platformio.ini #315

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

jekader
Copy link
Contributor

@jekader jekader commented Oct 12, 2023

Currently, platformio.ini defines multiple environments which are very similar.

Changes in this PR:

  • Use the extends option [1] to remove most duplication
  • Sort library lists, move those used across all envs to the common environment
  • Pin framework-arduinoespressif32 to version 2.0.14 since master is unstable due to 3.0.0 release

[1] https://docs.platformio.org/en/latest/projectconf/sections/env/options/advanced/extends.html

@foorschtbar
Copy link
Member

Awesome! I did not know the "extend" feature until now. Thanks for this PR.

@o0shojo0o
Copy link
Member

Thank you for your PR, I was not aware of extends .

@o0shojo0o o0shojo0o merged commit f552a76 into pixelit-project:develop Oct 12, 2023
1 check passed
@jekader jekader deleted the pio_dedup branch October 12, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants