Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Multiple issues in 4.0.0 #200

Open
dogawaf opened this issue Oct 8, 2024 · 1 comment
Open

[BUG] Multiple issues in 4.0.0 #200

dogawaf opened this issue Oct 8, 2024 · 1 comment

Comments

@dogawaf
Copy link
Contributor

dogawaf commented Oct 8, 2024

Since 4.0.0 and the compatibility with TYPO3 12, multiple issues have been introduced, especially with the migration from Slots to Events.

Example here https://github.com/pixelant/pxa_social_feed/blob/master/Classes/Feed/Update/TwitterV2FeedUpdater.php#L43 where $this->eventDispatcher is null.

Also, some introduced Events class are incompleted and are unusable, like BeforeReturnTwitterQueryFieldsEvent which need to provide the feed's Configuration object to listeners in order to be useful.

I will provide a PR to fix those issues.

Furthermore, I suggest to refactor the whole DI thing:

  • use constructor injection by default
  • adjust the Services.yaml file
  • fix tests

Because it's for 4.0.0, which is not yet available on TER, I think those breaking changes can be introduced.

What do you think?

@MattiasNilsson
Copy link
Contributor

@dogawaf Great add a PR and we will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants