Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for type annotations #772

Open
gpkc opened this issue Jun 1, 2023 · 3 comments
Open

Support for type annotations #772

gpkc opened this issue Jun 1, 2023 · 3 comments

Comments

@gpkc
Copy link

gpkc commented Jun 1, 2023

Is support for type annotations in the roadmap for this package? I think it would really benefit from it.
@mpenkov
Copy link
Collaborator

mpenkov commented Jun 1, 2023

I played around with it a bit earlier: #545

I'm not sure if it's really worth it for the entire package. Adding it for just the public-facing functions may be helpful. What do you think?

@gpkc
Copy link
Author

gpkc commented Jun 2, 2023

@mpenkov that can be useful yes, at least for IDE autocompletion and basic mypy verification

Do you think that PR is still up-to-date or it should be started again from scratch due to changes in the codebase?

@mpenkov
Copy link
Collaborator

mpenkov commented Jun 2, 2023

I'd do it from scratch because that PR did type annotations for everything, even internal stuff, which is overkill.

Are you up to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpenkov @gpkc