Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notation Mismatch : Documentation LDA and HDP #941

Closed
budhiraja opened this issue Oct 12, 2016 · 8 comments
Closed

Notation Mismatch : Documentation LDA and HDP #941

budhiraja opened this issue Oct 12, 2016 · 8 comments

Comments

@budhiraja
Copy link

Hi,
I have come across an instance where the notations in examples and APIs is different. In LDA and HDP the show_topics function takes arguments - num_topics=20 and num_words=20 where as in the following places, it is mistakenly reported as something else.

  1. http://christop.club/2014/05/06/using-gensim-for-lda/ : model.show_topics(topics=5, topn=5)
  2. https://radimrehurek.com/gensim/models/hdpmodel.html : hdp.print_topics(show_topics=20, num_words=10

It will be good to rectify these.

Thanks,
Amar

@bhargavvader
Copy link
Contributor

@dsquareindia , @tmylk , HDP is coming up often with regard to this... needs some cleaning up.

@budhiraja
Copy link
Author

Hi @bhargavvader is there an HDP tutorial somewhere? If I am right HDP build a topic hierarchy, is there a way to look at it? Even in a crude way - say parent-child relationship?

Thanks,
Amar

@bhargavvader
Copy link
Contributor

As far as I know, there is no tutorial nor is there a way to look at the topic hierarchy - though I have not used it extensively, and am unaware if it might exist. I'm going to raise an appropriate issue so someone can tackle it, but will wait for @tmylk or @dsquareindia to confirm if we have more HDP examples.

@tmylk tmylk changed the title Notation Mismatch : Documentation Notation Mismatch : Documentation LDA and HDP Oct 13, 2016
@tmylk
Copy link
Contributor

tmylk commented Oct 18, 2016

@markroxor should this be updated post #946 merge?

@markroxor
Copy link
Contributor

markroxor commented Oct 18, 2016

Not sure what you mean, do you want me to work on #945 ?

@markroxor
Copy link
Contributor

markroxor commented Oct 18, 2016

HDPModel now includes print_topics so 'hdp.print_topics(num_topics=20, num_words=10)' can now be executed but the tutorial for hdpmodel here should be updated as it states show_topics as an input parameter instead of num_topics.

I think this issue can be closed and we can move our discussion to #945 which is a superset of this issue.

@bhargavvader
Copy link
Contributor

Can this be closed now that the base class is made?

@tmylk
Copy link
Contributor

tmylk commented Nov 8, 2016

The doc has been regenerated at https://radimrehurek.com/gensim/models/hdpmodel.html

@tmylk tmylk closed this as completed Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants