Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "Pattern not installed" warning from import time to when lemmatization is used #1009

Closed
tmylk opened this issue Nov 13, 2016 · 2 comments
Closed

Move "Pattern not installed" warning from import time to when lemmatization is used #1009

tmylk opened this issue Nov 13, 2016 · 2 comments
Labels
difficulty easy Easy issue: required small fix wishlist Feature request

Comments

@tmylk
Copy link
Contributor

tmylk commented Nov 13, 2016

It confuses many first time users as the warning is the first thing they see when importing gensim.
@tmylk tmylk added difficulty easy Easy issue: required small fix wishlist Feature request labels Nov 13, 2016
@tmylk tmylk changed the title Move Pattern warning from import time to when lemmatization is used Move "Pattern not installed" warning from import time to when lemmatization is used Nov 13, 2016
@souravsingh
Copy link
Contributor

@tmylk I would like to work on the issue. How do I start?

@shashankg7
Copy link
Contributor

@tmylk , @souravsingh . I have fixed this issue. I moved 'has_pattern()' method's pattern installation check to lemmatize method. The warning will only occur when user calls the lemmatization method and if the pattern library is not installed. I also modified the call to "has_pattern" in corpora/wikicorpus's constructor.

Please refer to #1018

@shashankg7 shashankg7 mentioned this issue Nov 14, 2016
Merged
@tmylk tmylk closed this as completed in 80e9c98 Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty easy Easy issue: required small fix wishlist Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tmylk @shashankg7 @souravsingh