Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross site scripting (XSS) bug in Image upload #641

Closed
m0r3h4x opened this issue Feb 23, 2017 · 3 comments
Closed

Cross site scripting (XSS) bug in Image upload #641

m0r3h4x opened this issue Feb 23, 2017 · 3 comments
Assignees
Labels

Comments

@m0r3h4x
Copy link

m0r3h4x commented Feb 23, 2017

An XSS can be triggered if the user uploaded an image with an XSS vector as the file name.
screenshot from 2017-02-23 16 31 28

Steps to reproduce the bug

  1. Change Your image name , see the screenshot "Using xss payload as the name"
    screenshot from 2017-02-23 16 36 46

  2. Go to http://www.piskelapp.com/p/create

  3. Click on import and then browse images and select your image

  4. Voila XSS triggered 😄

Environment details

Linux Os
Firefox Browser

You can simply stop reflecting the file name into the page, it's not needed anyways. 👍

@juliandescottes
Copy link
Collaborator

Thanks for the report and great point!

Looks like we have a similar issue if you use it as your sprite name when saving to your gallery.
For reference here's your example string to use for testing.

><img src=x onerror=prompt(1)>

@m0r3h4x
Copy link
Author

m0r3h4x commented Feb 23, 2017

Yeah the Same problem and you're most welcome

@juliandescottes
Copy link
Collaborator

The main issue should now be fixed (still needs to be released to piskelapp.com however).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants