Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Missing French Localization #24

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

maxime-killinger
Copy link
Contributor

Fix for #23

@maxime-killinger maxime-killinger changed the title Fix Missing French Localization #23 Fix Missing French Localization Nov 24, 2020
@piscoTech piscoTech changed the base branch from french to master November 24, 2020 17:24
Copy link
Owner

@piscoTech piscoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.
Besides the minor tweaks, can you rebase on top of master to simplify the merge?

Workout/fr.lproj/Localizable.strings Outdated Show resolved Hide resolved
Workout/fr.lproj/Localizable.strings Show resolved Hide resolved
Workout/fr.lproj/Localizable.strings Outdated Show resolved Hide resolved
Workout/fr.lproj/Localizable.strings Outdated Show resolved Hide resolved
@maxime-killinger
Copy link
Contributor Author

Sorry for the delays, I've been really busy this past year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants