Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] One Tab extention integration with Tree Style Tab extention #2914

Closed
JattMones opened this issue Jun 2, 2021 · 5 comments
Labels
extension-compatibility conflict with another addon

Comments

@JattMones
Copy link

JattMones commented Jun 2, 2021

Short description

[feature request] OneTab & Tree Style Tab Integration

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install OneTab and Tree Style Tab
  3. Open tabs and organize them in a tree structure using tree style tab
  4. Close/save the open tabs with the OneTab extension
  5. Open a new Firefox window and re-load the saved tabs using the OneTab extension

Expected result

Tabs are still stored in previous tree structure when loaded from OneTab.

Actual result

(Most) Tabs are knocked out so they all resemble "root tabs"

  • Note: I've seen some inconsistent behavior with some tabs (Specifically a download tab opened after starting a download) sometimes stays as child tabs within Tree Style Tab.
  • I noticed this once when downloading OBS from this page, the "welcome to obs" tab which pops up afterward stays as a child tab when re-loading tabs from onetab. However, after re-testing I did not get the same behavior

Environment

  • Platform (OS): Mac
  • Version of Firefox: 89

I've also sent a message to the onetab support team, and made sure to include the link to this issue. I think it would make the most sense if OneTab stored Tree Style Tab information with it's saved tabs, although I'm not sure if this is possible. This info would then be sent to Tree Style Tab when the tabs are being loaded, so that Tree Style Tab knows how to organize them.
onetab request

All this being said, it's not really my concern HOW it works. Having OneTab supply data to Tree Style Tab seems like a long shot. If there is a better/easier way for you to integrate these two extensions together, please do it. Just thought I'd throw out a suggestion. Many thanks!

@piroor
Copy link
Owner

piroor commented Jun 3, 2021

I think there is nothing TST side can do about this. If OneTab stores and restores openerTabId information of tabs like TSM, TST can construct tree structure from the information. In other words, TST cannot reconstruct tree structure with no hint, until OneTab become providing that.

Tab's openerTabId is generic, and not TST specific. If OneTab starts to use the information, integration with OneTab will be improved more about other tree-view tab management addons also.

@piroor piroor added the extension-compatibility conflict with another addon label Jun 3, 2021
@irvinm
Copy link
Contributor

irvinm commented Jun 12, 2021

@JattMones will you close this item? There is nothing to do on the TST side. Adding support for the openerTabId property is very simple and is the information that TST needs to be able to track relationships.

@irvinm
Copy link
Contributor

irvinm commented Jun 19, 2021

@piroor I think this one can be closed.

@bjwest
Copy link

bjwest commented Jul 2, 2021

I'd rather see TST replace OneTab with it's own tab organizing system. The method OneTab uses to import and export the database is atrocious. OneTab has done a great job in hiding it's data so there's no way to extract it externally, and my tab "library" is larger than can be handled by the clipboard.

@piroor
Copy link
Owner

piroor commented Jul 3, 2021

I've added a FAQ topic "Better compatibility with session manager extensions, or add high-power session management feature" based on this thread.
https://github.com/piroor/treestyletab/blob/trunk/README.md#feature-requests

@piroor piroor closed this as completed Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension-compatibility conflict with another addon
Projects
None yet
Development

No branches or pull requests

4 participants