-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redux-saga usage docs #175
Labels
Comments
Hey @Kamahl19, thanks for the heads up. Are you able to provide an updated example? |
I'm also interested in this. Actually the example with saga in the README doesn't work :/ |
@pybuche what do you mean |
There is a typo in the code example, but I realized it only a few hours ago :) function* addTodoSaga(action: ReturnType<typeof fetchTodosAsync.request>): Generator {
try { // missing this line
const response: Todo[] = yield call(todosApi.getAll, action.payload);
yield put(fetchTodosAsync.success(response));
} catch (err) {
yield put(fetchTodosAsync.failure(err));
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Redux-saga solved (microsoft/TypeScript#30790) the long-opened issue (microsoft/TypeScript#2983) mentioned in docs https://github.com/piotrwitek/typesafe-actions#with-redux-saga-sagas , so I suppose they can be updated with better example
The text was updated successfully, but these errors were encountered: